Add iterwalk package to speed up large directory listing #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for raredocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #149 +/- ##
==========================================
- Coverage 93.49% 93.28% -0.22%
==========================================
Files 142 143 +1
Lines 7446 7494 +48
==========================================
+ Hits 6962 6991 +29
- Misses 363 379 +16
- Partials 121 124 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zix99
commented
Jun 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, filepath.WalkDir gathers all files and sorts before outputing. On testing with a directory with over a million small files, this leads to a multi-second start lag.
This slightly forks and changes the WalkDir command to iterate on a directory. This removes sorting (CPU improvement), and speeds up the initial request significantly. (Negligible). For some reason this method is ever so slightly slower than filepath.WalkDir (few microseconds), but average use that won't be noticeable, and for large searches this will be a significant improvement.