Fix Issue #31 TagMacro: resolve parameters inside type bounds & wildcards #537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@cmofx Great work! 👍 Could you please also tests for recursive bound case, such as |
Just added the support for recursive bound case, updated the SharedTagTest.scala |
pshirshov
approved these changes
Apr 30, 2025
|
Looks nice for me, thank you for your help. |
neko-kai
approved these changes
May 4, 2025
izumi-reflect/izumi-reflect/src/main/scala/izumi/reflect/macrortti/LightTypeTag.scala
Outdated
Show resolved
Hide resolved
|
Updated the way to map LightTypeTag.ref to AbstractReference |
neko-kai
reviewed
May 5, 2025
izumi-reflect/izumi-reflect/src/main/scala-2/izumi/reflect/ReflectionUtil.scala
Outdated
Show resolved
Hide resolved
izumi-reflect/izumi-reflect/src/test/scala/izumi/reflect/test/SharedTagTest.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #31
I added new function wildcardType in LightTypeTag to create bounds wildcard type tag.
Also changed the TacMacro in scala 3 and scala 2 to parse the tag type bound parameters and summon the type tags accordingly
Also fixed a bug in the scala 2 ReflectionUtil.scala that TypeBound's lower bound is not checked for strong type