Remove printing / logging to console during tests and reduce testsuite execution time #9896
Conversation
| @@ -34,7 +34,7 @@ object OneShotSpec extends ZIOBaseSpec { | |||
| test("get must fail if no value is set") { | |||
| val oneShot = OneShot.make[Object] | |||
|
|
|||
| assert(oneShot.get(10000L))(throwsA[Error]) | |||
| assert(oneShot.get(10L))(throwsA[Error]) | |||
There was a problem hiding this comment.
is this because 10000 allocates, but 10 does not?
There was a problem hiding this comment.
That is the timeout waiting for a value. The test checks that if OneShot is not completed it will timeout and throw and error. Previously the timeout was set to 10 seconds which meant the suite simply had to wait for 10 seconds before completing, now it has to wait just 10ms
There was a problem hiding this comment.
Ah lol, not sure what I was thinking.
| @@ -201,7 +201,7 @@ object TestProvideSpec extends ZIOBaseSpec { | |||
| } yield IntService(ref)) | |||
|
|
|||
| val stringService: ULayer[StringService] = | |||
| ZLayer(Ref.make("Hello").map(StringService(_)).debug("MAKING")) | |||
| ZLayer(Ref.make("Hello").map(StringService(_))) | |||
There was a problem hiding this comment.
I think there are some layers that use println directly as well...
There was a problem hiding this comment.
Those ones are coming from the typeCheck macro but I can't for the life of me figure out where the printing is happening :/ It looks like it only happens when type-checking the result of macros
This PR is to make things a bit more DX friendly by: