Skip to content

feat: add privilege group management functions #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

SimFG
Copy link
Collaborator

@SimFG SimFG commented May 20, 2025

  • Implement CreatePrivilegeGroup, DropPrivilegeGroup, and OperatePrivilegeGroup methods in DataHandler and MilvusDataHandler.
  • Update ChannelWriter to handle new privilege group messages.
  • Modify IsUserRoleMessage function to include new privilege group message types.
  • Update cdc.yaml to change etcd address from 12379 to 2379.
  • Upgrade Go dependencies and update go.mod and go.sum files.

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 21.35922% with 81 lines in your changes missing coverage. Please review.

Project coverage is 39.92%. Comparing base (614d86a) to head (206e70c).

Files with missing lines Patch % Lines
core/writer/channel_writer.go 40.00% 33 Missing ⚠️
core/writer/milvus_handler.go 0.00% 33 Missing ⚠️
core/api/data_handler.go 0.00% 9 Missing ⚠️
core/util/msgpack.go 0.00% 4 Missing ⚠️
server/cdc_impl.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
- Coverage   40.19%   39.92%   -0.27%     
==========================================
  Files          78       78              
  Lines       14194    14275      +81     
==========================================
- Hits         5705     5700       -5     
- Misses       8106     8191      +85     
- Partials      383      384       +1     
Files with missing lines Coverage Δ
core/api/param.go 0.00% <ø> (ø)
server/cdc_impl.go 58.27% <0.00%> (ø)
core/util/msgpack.go 9.58% <0.00%> (-0.42%) ⬇️
core/api/data_handler.go 59.37% <0.00%> (-6.15%) ⬇️
core/writer/channel_writer.go 50.00% <40.00%> (-1.46%) ⬇️
core/writer/milvus_handler.go 52.62% <0.00%> (-3.76%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Implement CreatePrivilegeGroup, DropPrivilegeGroup, and OperatePrivilegeGroup methods in DataHandler and MilvusDataHandler.
- Update ChannelWriter to handle new privilege group messages.
- Modify IsUserRoleMessage function to include new privilege group message types.
- Update cdc.yaml to change etcd address from 12379 to 2379.
- Upgrade Go dependencies and update go.mod and go.sum files.

Signed-off-by: SimFG <bang.fu@zilliz.com>
@bigsheeper
Copy link
Collaborator

/lgtm

@sre-ci-robot sre-ci-robot merged commit 0cf1c45 into zilliztech:main May 20, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants