Skip to content

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Apr 16, 2025

No description provided.

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 41.77%. Comparing base (8608cae) to head (b3c078f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
server/writer_callback.go 0.00% 14 Missing ⚠️
server/cdc_impl.go 0.00% 13 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
- Coverage   41.85%   41.77%   -0.09%     
==========================================
  Files          73       73              
  Lines       13219    13246      +27     
==========================================
  Hits         5533     5533              
- Misses       7205     7232      +27     
  Partials      481      481              
Files with missing lines Coverage Δ
server/cdc_impl.go 58.53% <0.00%> (-0.59%) ⬇️
server/writer_callback.go 65.85% <0.00%> (-34.15%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhuwenxing
Copy link
Collaborator

/lgtm

@sre-ci-robot sre-ci-robot merged commit 8645b78 into zilliztech:main Apr 17, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants