Skip to content

Conversation

SimFG
Copy link
Collaborator

@SimFG SimFG commented Apr 13, 2025

No description provided.

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.89%. Comparing base (d60dcff) to head (c5069e2).

Files with missing lines Patch % Lines
server/cdc_impl.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
+ Coverage   41.87%   41.89%   +0.01%     
==========================================
  Files          73       73              
  Lines       13210    13207       -3     
==========================================
+ Hits         5532     5533       +1     
+ Misses       7196     7193       -3     
+ Partials      482      481       -1     
Files with missing lines Coverage Δ
core/reader/channel_reader.go 61.87% <100.00%> (+2.01%) ⬆️
server/cdc_impl.go 59.11% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bigsheeper
Copy link
Collaborator

/lgtm

@sre-ci-robot sre-ci-robot merged commit 147d890 into zilliztech:main Apr 14, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants