Skip to content

feat: support to replicate rbac message to kafka #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Sep 23, 2024
Merged

feat: support to replicate rbac message to kafka #122

merged 21 commits into from
Sep 23, 2024

Conversation

Ricky-chen1
Copy link
Contributor

@Ricky-chen1 Ricky-chen1 commented Aug 29, 2024 •
edited
Loading

  1. add kafka rbac replication func
  2. [WIP]: complete kafka ci test
  3. let target collectionInfo equal to source collectionInfo when downstream is not milvus
  4. add createRequest unit test when downstream is kafka

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 70.27027% with 110 lines in your changes missing coverage. Please review.

Project coverage is 64.50%. Comparing base (bc2d58e) to head (e8153fb).

Files with missing lines Patch % Lines
core/reader/replicate_channel_manager.go 42.62% 65 Missing and 5 partials ⚠️
server/cdc_impl.go 85.61% 16 Missing and 4 partials ⚠️
core/writer/kafka_handler.go 85.41% 12 Missing and 2 partials ⚠️
core/util/milvus_client_resource.go 0.00% 3 Missing ⚠️
core/writer/kafka_formatter.go 70.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
- Coverage   64.56%   64.50%   -0.07%     
==========================================
  Files          52       52              
  Lines        6988     7189     +201     
==========================================
+ Hits         4512     4637     +125     
- Misses       2186     2256      +70     
- Partials      290      296       +6
Files with missing lines Coverage Δ
core/writer/channel_writer.go 61.66% <ø> (ø)
core/util/milvus_client_resource.go 73.84% <0.00%> (-3.58%) ⬇️
core/writer/kafka_formatter.go 67.39% <70.00%> (-7.08%) ⬇️
core/writer/kafka_handler.go 82.50% <85.41%> (+3.44%) ⬆️
server/cdc_impl.go 60.88% <85.61%> (+2.13%) ⬆️
core/reader/replicate_channel_manager.go 53.74% <42.62%> (-1.82%) ⬇️

SimFG
SimFG reviewed Sep 16, 2024
View reviewed changes
@SimFG SimFG merged commit 63180d1 into zilliztech:main Sep 23, 2024
3 of 4 checks passed
@Ricky-chen1 Ricky-chen1 deleted the feat-rbac2kafka branch September 27, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimFG SimFG SimFG left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ricky-chen1 @codecov-commenter @SimFG