Skip to content
This repository was archived by the owner on Nov 13, 2024. It is now read-only.

Added hex transparency #17

Merged
merged 3 commits into from
Aug 16, 2022
Merged

Added hex transparency #17

merged 3 commits into from
Aug 16, 2022

Conversation

lars-vc
Copy link
Contributor

@lars-vc lars-vc commented Aug 15, 2022

Added hex transparency to the back of hex codes
closes #16
closes #18

@ziontee113
Copy link
Owner

ziontee113 commented Aug 15, 2022

Hi @lars-vc , thank you very much for submitting the PR.
I tried it out and things are looking good.

One small question I have is that the Transparent HEX value should be at the beginning instead of at the end? According to:
https://stackoverflow.com/a/23201304/19205063
https://gist.github.com/lopspower/03fb1cc0ac9f32ef38f4

But there are information like this
https://webtools.fineaty.com/ColorInfo/FFFFFF00/en/Information-about-the-FFFFFF00-color.html

I'm unfamiliar with Transparent HEX colors so I can't tell 😄. What do you think about putting Transparent HEX information at the beginning or at the end? Thank you :)

@ziontee113
Copy link
Owner

Also I forgot about when you open the Color Picker when your cursor is on a color, the Color Picker should pick up the color under your cursor. Maybe we can add the feature for Transparent HEX colors in the future?

@lars-vc
Copy link
Contributor Author

lars-vc commented Aug 15, 2022

Hi @lars-vc , thank you very much for submitting the PR. I tried it out and things are looking good.

One small question I have is that the Transparent HEX value should be at the beginning instead of at the end? According to: https://stackoverflow.com/a/23201304/19205063 https://gist.github.com/lopspower/03fb1cc0ac9f32ef38f4

But there are information like this https://webtools.fineaty.com/ColorInfo/FFFFFF00/en/Information-about-the-FFFFFF00-color.html

I'm unfamiliar with Transparent HEX colors so I can't tell 😄. What do you think about putting Transparent HEX information at the beginning or at the end? Thank you :)

It is a bit of a toss up, but CSS uses at the back (https://stackoverflow.com/questions/1751263/hex-colors-numeric-representation-for-transparent). So that's why I picked at the back.

@lars-vc
Copy link
Contributor Author

lars-vc commented Aug 15, 2022

Also I forgot about when you open the Color Picker when your cursor is on a color, the Color Picker should pick up the color under your cursor. Maybe we can add the feature for Transparent HEX colors in the future?

Ah I forgot about this, Ill fix it tmrw!

@ziontee113
Copy link
Owner

ziontee113 commented Aug 15, 2022

Ah I forgot about this, Ill fix it tmrw!

Thank you very much. I'm sorry in advance because that part of the code base is a bit amateurish 😄

@lars-vc
Copy link
Contributor Author

lars-vc commented Aug 16, 2022

Added!

@ziontee113 ziontee113 merged commit d06fd00 into ziontee113:master Aug 16, 2022
@ziontee113
Copy link
Owner

Thank you very much @lars-vc for the amazing PR 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Pressing ctrl+c while in the menu opens another one [Feature request] transparency with hex codes
2 participants