Switch to Myers diff #982
Merged
Switch to Myers diff #982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Extremely weird CI failure... (Compiler issue?) |
4e6492a to
95700e7
Compare
Weird. |
|
Solution found: implementing diffmatchpatch in its entirety, in Zig, live on stream :P |
leecannon
approved these changes
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #979;
I originally ripped off gopls' Myers Difference Algorithm implementation, but realized that it did not fit our usecase, so I instead wrote about 2000 lines of code for a Zig DiffMatchPatch impl w/ Travis, which is what this PR uses! :)
Confirmed working by adding a new, correct diff patch implementation (which we should probably start using in the future) to
diff.zigand getting tests running.