Skip to content

implement cInclude completions & goto definition #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 11, 2023
Merged

implement cInclude completions & goto definition #970

merged 4 commits into from
Feb 11, 2023

Conversation

Techatrix
Copy link
Member

@Techatrix Techatrix commented Feb 5, 2023 •
edited
Loading

  • implemented completions inside @cInclude()
  • implemented goto definition on @embedFile()
  • imlemented goto definition on @cInclude()

I have not tested this on windows yet so there may be some bugs still lurking around.

Should close #974.

@Techatrix Techatrix marked this pull request as ready for review February 5, 2023 11:04
@Techatrix Techatrix marked this pull request as draft February 5, 2023 11:06
@Techatrix Techatrix marked this pull request as ready for review February 5, 2023 17:28
@leecannon
Copy link
Member

leecannon commented Feb 11, 2023 •
edited
Loading

Looks like the @embedFile and @import goto definition does not support ..

It works fine for @import on master

@leecannon leecannon merged commit 37ca133 into zigtools:master Feb 11, 2023
@Techatrix Techatrix deleted the cimport-completions-definition branch May 5, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecannon leecannon leecannon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C functions and struct fields does not complete
2 participants
@Techatrix @leecannon