Skip to content

Use zig-lsp-codegen #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Dec 27, 2022
Merged

Use zig-lsp-codegen #850

merged 21 commits into from
Dec 27, 2022

Conversation

Techatrix
Copy link
Member

Thanks to @SuperAuguste we can use https://github.com/zigtools/zig-lsp-codegen to automatically create zig types for the LSP Specification, which more complete and accurate. From the users point of view not much should be changed.

I've also used this opportunity to rework zls's message handler processJsonRpc.
https://github.com/ziglibs/tres has been added as a submodule.

@SuperAuguste
Copy link
Member

So I've been working on this exact same thing in use-zig-lsp but with some of the issues you mention (like typechecking responses, for example) addressed. Not sure how to address both of these solutions existing. Maybe I can merge this and then try to rebase my work onto your branch?

@Techatrix Techatrix mentioned this pull request Dec 27, 2022
Merged
@SuperAuguste SuperAuguste merged commit 61c0981 into zigtools:master Dec 27, 2022
@Techatrix Techatrix deleted the zig-lsp branch January 3, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperAuguste SuperAuguste SuperAuguste approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Techatrix @SuperAuguste