Skip to content

Format with Ast.render instead of zig fmt #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2022
Merged

Format with Ast.render instead of zig fmt #755

merged 1 commit into from
Nov 16, 2022

Conversation

Techatrix
Copy link
Member

We don't need to call zig fmt because we can format the code ourself with std.zig.Ast.render. This should provide a more stable experience with formatting because don't need to spawn a child process and don't depend on a zig executable for formatting.

SuperAuguste
SuperAuguste approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@SuperAuguste SuperAuguste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing.

@SuperAuguste SuperAuguste merged commit 662b560 into zigtools:master Nov 16, 2022
@Techatrix Techatrix deleted the fmt-with-tree-render branch November 16, 2022 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperAuguste SuperAuguste SuperAuguste approved these changes

+1 more reviewer

@nektro nektro nektro approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Techatrix @nektro @SuperAuguste