Skip to content

Improve unused variable report accuracy #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2022
Merged

Improve unused variable report accuracy #585

merged 1 commit into from
Aug 20, 2022

Conversation

InKryption
Copy link
Contributor

@InKryption InKryption commented Aug 19, 2022 •
edited
Loading

With unused variable warnings enabled, this code

const blk = blk: {
    break :blk;
};
blk: for ([_]void{}) |_| break :blk;
blk: while (false) break :blk;
_ = .blk;
_ = .{ .blk = .foo };

would have previously reported the blk variable as being used. With some extra checks for some surrounding tokens, blk should now be correctly reported as unused.

@SuperAuguste
Copy link
Member

Fantastic, thanks!

@SuperAuguste SuperAuguste merged commit 07ae21a into zigtools:master Aug 20, 2022
@leecannon leecannon mentioned this pull request Aug 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@InKryption @SuperAuguste