Skip to content

fix ast.lastToken() does not handle empty error_value #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2022
Merged

fix ast.lastToken() does not handle empty error_value #476

merged 1 commit into from
Apr 20, 2022

Conversation

v1nh1shungry
Copy link
Contributor

Fix #475
When we type only error, both the lhs and rhs of the error_value node are 0. However, ast.lastToken() does not handle this, and it can cause zls to crash. This commit is to fix this.

@SuperAuguste
Copy link
Member

Thanks!

@SuperAuguste SuperAuguste merged commit 256d7b7 into zigtools:master Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic when showing suggestions for error
2 participants
@v1nh1shungry @SuperAuguste