Skip to content

Skip char and string literals when highlighting comments #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2022
Merged

Skip char and string literals when highlighting comments #463

merged 1 commit into from
Mar 2, 2022

Conversation

cascade256
Copy link
Contributor

The comment highlighting appears to take priority over string and char literals, leading to syntax highlighting like this:
image

These changes should make it skip string and char literals when scanning for comments.

@Jarred-Sumner
Copy link
Contributor

nice

@nektro
Copy link
Contributor

nektro commented Feb 22, 2022

can you post a screenshot of what it looks like with these changes

@cascade256
Copy link
Contributor Author

Yep! Here is what it looks like:
image

@SuperAuguste
Copy link
Member

Thanks!

@SuperAuguste SuperAuguste merged commit 706413e into zigtools:master Mar 2, 2022
@jcmoyer jcmoyer mentioned this pull request Mar 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cascade256 @Jarred-Sumner @nektro @SuperAuguste