Skip to content

Conversation

davidgmbb
Copy link
Contributor

Hi there, first open source contribution to other project. Please review the PR and comment if you see anything wrong.
This fixes a crash when the ZLS configuration file could not be found and yet still the value of the string wasn't null.

@srccde
Copy link

srccde commented Feb 18, 2022

Is there a reason, this has not yet been merged? I've had this fix running locally for weeks now (independently from this PR, though).
The problem is simply that config_path is set to a path before it has been checked whether there's actually a config file there - and then is not reset to null if not. Ideally, it should only be set after the call to loadConfigInFolder, that is, within the If-statement.

@SuperAuguste SuperAuguste merged commit 14698c3 into zigtools:master Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants