Add option to truncate long completions #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The detail entries for big structs such as std.zig.CrossTarget were bricking the preview window in Sublime Text.
|
Looks good |
Techatrix
added a commit
that referenced
this pull request
Sep 25, 2023
`enable_import_embedfile_argument_completions` existed because this option has been buggy in the past but not anymore. `include_at_in_builtins` is a workaround for builtin completions in sublime text 3 which can instead be detected by inspecting the clientInfo in initialize request. `max_detail_length` is a workaround for long completion detail entries bricking the preview window in Sublime Text #261 which can also detected through the clientInfo field. `operator_completions` this option has been added when this feature was implemented but is there anyone who needs it?
Techatrix
added a commit
that referenced
this pull request
Sep 25, 2023
`enable_import_embedfile_argument_completions` existed because this option has been buggy in the past but not anymore. `include_at_in_builtins` is a workaround for builtin completions in sublime text 3 which can instead be detected by inspecting the `clientInfo` field in initialize request. `max_detail_length` is a workaround for long completion detail entries bricking the preview window in Sublime Text #261 which can also be detected through the `clientInfo` field. `operator_completions` this option has been added when this feature was implemented but is there anyone who needs it?
Techatrix
added a commit
that referenced
this pull request
Sep 25, 2023
`enable_import_embedfile_argument_completions` existed because this option has been buggy in the past but not anymore. `include_at_in_builtins` is a workaround for builtin completions in sublime text 3 which can instead be detected by inspecting the `clientInfo` field in initialize request. `max_detail_length` is a workaround for long completion detail entries bricking the preview window in Sublime Text #261 which can also be detected through the `clientInfo` field. `operator_completions` this option has been added when this feature was implemented but is there anyone who needs it?
SuperAuguste
pushed a commit
that referenced
this pull request
Oct 1, 2023
`enable_import_embedfile_argument_completions` existed because this option has been buggy in the past but not anymore. `include_at_in_builtins` is a workaround for builtin completions in sublime text 3 which can instead be detected by inspecting the `clientInfo` field in initialize request. `max_detail_length` is a workaround for long completion detail entries bricking the preview window in Sublime Text #261 which can also be detected through the `clientInfo` field. `operator_completions` this option has been added when this feature was implemented but is there anyone who needs it?
KoltPenny
pushed a commit
to KoltPenny/zls
that referenced
this pull request
Oct 18, 2023
`enable_import_embedfile_argument_completions` existed because this option has been buggy in the past but not anymore. `include_at_in_builtins` is a workaround for builtin completions in sublime text 3 which can instead be detected by inspecting the `clientInfo` field in initialize request. `max_detail_length` is a workaround for long completion detail entries bricking the preview window in Sublime Text zigtools#261 which can also be detected through the `clientInfo` field. `operator_completions` this option has been added when this feature was implemented but is there anyone who needs it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The detail entries for big structs such as
std.zig.CrossTargetwere bricking the preview window in Sublime Text.I needed to increase the EvalBranchQuota of the json parser to add this option even though it is just a single integer. Maybe we should evaluate the build time impact of adding config options and consider alternatives (TOML?)