revive C import support #1136

Techatrix · 2023-04-16T22:40:00Z

Its time to bring back C import support. fixes #1080
Please feel free to try this out and report any issues.

error reporting currently doesn't work because of an issue on the zig side (I suspect)

silversquirl · 2023-04-17T10:10:48Z

Doesn't seem to be working for me - translate-c errors out with UnexpectedEOF

Full zls log:

info : (config): Using zig executable '/home/silver/.local/bin/zig'
info : (config): Using zig lib path '/home/silver/.opt/zig/lib'
info : (config): Using build runner global cache path '/home/silver/.cache/zig'
info : (config): Detected runtime zig version: '0.11.0-dev.2614+7b908e173'
info : (server): client is 'kak-lsp-14.2.0'
info : (server): zls initializing
info : (server): Server.ClientCapabilities{ .supports_snippets = false, .supports_apply_edits = true, .supports_will_save = false, .supports_will_save_wait_until = false, .supports_publish_diagnostics = true, .supports_code_action_fixall = false, .hover_supports_md = true, .completion_doc_supports_md = true, .label_details_support = false, .supports_configuration = true, .supports_workspace_did_change_configuration_dynamic_registration = false }
info : (server): Using offset encoding: utf-8
warning: (store ): Document already open: file:///home/silver/code/pipit/src/CodeGen.zig
info : (server): Setting configuration...
info : (config): Using zig executable '/home/silver/.local/bin/zig'
info : (config): Using zig lib path '/home/silver/.opt/zig/lib'
info : (config): Using build runner global cache path '/home/silver/.cache/zig'
info : (config): Detected runtime zig version: '0.11.0-dev.2614+7b908e173'
info : (server): Setting configuration...
info : (config): Using zig executable '/home/silver/.local/bin/zig'
info : (config): Using zig lib path '/home/silver/.opt/zig/lib'
info : (config): Using build runner global cache path '/home/silver/.cache/zig'
info : (config): Detected runtime zig version: '0.11.0-dev.2614+7b908e173'
info : (server): Setting configuration...
info : (config): Using zig executable '/home/silver/.local/bin/zig'
info : (config): Using zig lib path '/home/silver/.opt/zig/lib'
info : (config): Using build runner global cache path '/home/silver/.cache/zig'
info : (config): Detected runtime zig version: '0.11.0-dev.2614+7b908e173'
info : (server): Setting configuration...
info : (config): Using zig executable '/home/silver/.local/bin/zig'
info : (config): Using zig lib path '/home/silver/.opt/zig/lib'
info : (config): Using build runner global cache path '/home/silver/.cache/zig'
info : (config): Detected runtime zig version: '0.11.0-dev.2614+7b908e173'
error: (translate_c): failed zig translate-c command:
/home/silver/.local/bin/zig translate-c --zig-lib-dir /home/silver/.opt/zig/lib --cache-dir /home/silver/.cache/zls -lc --listen=- -I /usr/local/include -I /usr/include/x86_64-linux-gnu -I /usr/include /home/silver/.cache/zls/cimport.h
error:error.UnexpectedEOF

error: (store ): failed to translate cimport: error.UnexpectedEOF

Techatrix · 2023-04-17T10:17:21Z

Doesn't seem to be working for me - translate-c errors out with UnexpectedEOF

I didn't check on Windows, it should work now.

silversquirl · 2023-04-17T10:30:51Z

I'm on Linux, and using the latest commit in this branch :)

Techatrix · 2023-04-17T10:36:05Z

I should have read that log more carefully, my bad. I thought I just fixed that error.

silversquirl · 2023-04-17T10:43:22Z

No error any more, but still no completions. It works when I @cImport(@cInclude("stdlib.h")) outside of a project though - seems like it's just not working with headers from packages?

Techatrix · 2023-04-17T10:48:59Z

resolving include paths from build.zig may not work correctly anymore. I will check later if something regressed.

recursiveGecko · 2023-05-01T23:00:13Z

I had to change a few things to make it build with Zig 0.11.0-dev.2935+ec6ffaa1e, but I'm now getting completions! 🚀

Screenshot

Patch

diff --git a/src/analyser/InternPool.zig b/src/analyser/InternPool.zig
index 42f3afb..5a68ee2 100644
--- a/src/analyser/InternPool.zig
+++ b/src/analyser/InternPool.zig
@@ -3315,15 +3315,15 @@ test "bytes value" {

     var str1: [43]u8 = "https://www.youtube.com/watch?v=dQw4w9WgXcQ".*;
     const bytes_value1 = try ip.get(gpa, .{ .bytes = &str1 });
-    @memset(&str1, 0, str1.len);
+    @memset(&str1, 0);

     var str2: [43]u8 = "https://www.youtube.com/watch?v=dQw4w9WgXcQ".*;
     const bytes_value2 = try ip.get(gpa, .{ .bytes = &str2 });
-    @memset(&str2, 0, str2.len);
+    @memset(&str2, 0);

     var str3: [26]u8 = "https://www.duckduckgo.com".*;
     const bytes_value3 = try ip.get(gpa, .{ .bytes = &str3 });
-    @memset(&str3, 0, str3.len);
+    @memset(&str3, 0);

     try expect(bytes_value1 == bytes_value2);
     try expect(bytes_value2 != bytes_value3);
diff --git a/src/main.zig b/src/main.zig
index b3e6251..6636e61 100644
--- a/src/main.zig
+++ b/src/main.zig
@@ -345,7 +345,7 @@ const stack_frames = switch (zig_builtin.mode) {

 pub fn main() !void {
     var gpa_state = std.heap.GeneralPurposeAllocator(.{ .stack_trace_frames = stack_frames }){};
-    defer std.debug.assert(!gpa_state.deinit());
+    defer std.debug.assert(gpa_state.deinit() == .ok);

     var tracy_state = if (tracy.enable_allocation) tracy.tracyAllocator(gpa_state.allocator()) else void{};
     const inner_allocator: std.mem.Allocator = if (tracy.enable_allocation) tracy_state.allocator() else gpa_state.allocator();

neurocyte · 2023-05-02T14:25:59Z

This works well for me when rebased to zls master.

bernardassan · 2023-05-09T21:43:41Z

@Techatrix thanks for your work on this feature. Completions currently work but hover for identifier information doesn't work.

In neovim 0.9.0 I get

Error executing vim.schedule lua callback: /usr/share/nvim/runtime/lua/vim/lsp/util.lua:1682: 'width' key must be a positive Integer
stack traceback:
	[C]: in function 'nvim_open_win'
	/usr/share/nvim/runtime/lua/vim/lsp/util.lua:1682: in function 'handler'
	/usr/share/nvim/runtime/lua/vim/lsp.lua:1394: in function ''
	vim/_editor.lua: in function <vim/_editor.lua:0>

on hover

Techatrix · 2023-05-09T21:55:33Z

Can you provide me with an example and steps you took to get this error? Information on your neovim setup would also be appreciated because I don't have much experience dealing with neovim.

bernardassan · 2023-05-10T15:27:30Z

Steps to reproduce the error

fetch and switch to this pr branch
compile with zig build -Doptimize=ReleaseFast
go into a zig project with c files example
on line 23 move to cnet.bind with you cursor on bind in normal mode
type :=vim.lsp.buf.hover() .ie command for lsp hover
the specified error is returned.
when all ui plugins are disabled(.ie comment out content in lua/plugins/ui.lua of my config) you get No information available
But if you move to a zig identifier or function you get hover information

NOTE: may neovim configuration

leecannon · 2023-05-30T16:32:08Z

Works on all my projects that use cimport.

Including a non-existant file results in an error in the log but zls keeps going 👍

Error

debug: (server): Took 1ms to process method textDocument/didChange
error: (translate_c): failed zig translate-c command:
/home/lee/bin/zig translate-c --zig-lib-dir /home/lee/zig/0.11.0-dev.3322+82632aff2/files/lib --cache-dir /home/lee/.cache/zls -lc --listen=- -I /usr/local/include -I /usr/include/x86_64-linux-gnu -I /usr/include -I /home/lee/src/zig-libgit2/../libgit2/include /home/lee/.cache/zls/cimport.h
error:error.Timeout

error: (store ): failed to translate cimport: error.Timeout
debug: (server): Took 29ms to process method textDocument/completion

Techatrix · 2023-06-11T23:01:45Z

Completions currently work but hover for identifier information doesn't work.

@Ultra-Code #1232 should have fixed your hover issue. (nice nvim config btw)

bernardassan · 2023-06-12T10:28:39Z

@Techatrix thanks for the fix, Indeed the hover works now 😄 .

Techatrix self-assigned this Apr 16, 2023

Techatrix force-pushed the revive-translateC branch 2 times, most recently from 35ba14c to 82f9199 Compare April 17, 2023 10:04

Techatrix force-pushed the revive-translateC branch from 82f9199 to 106a864 Compare April 17, 2023 10:35

leecannon force-pushed the revive-translateC branch from 106a864 to ea6c626 Compare May 2, 2023 16:54

leecannon added the pr:fuzz Attach to a PR to start fuzzing / continually fuzz (please do this before merging!) label May 2, 2023

Techatrix force-pushed the revive-translateC branch from ea6c626 to b8d7a71 Compare May 9, 2023 18:00

Techatrix force-pushed the revive-translateC branch from b8d7a71 to beda996 Compare May 29, 2023 22:04

Techatrix marked this pull request as ready for review May 29, 2023 23:31

revive translateC support

b623f14

Techatrix force-pushed the revive-translateC branch from beda996 to b623f14 Compare May 29, 2023 23:59

leecannon approved these changes May 30, 2023

View reviewed changes

leecannon merged commit 54f4768 into zigtools:master May 30, 2023

Techatrix deleted the revive-translateC branch May 30, 2023 17:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

revive C import support #1136

revive C import support #1136

Uh oh!

Techatrix commented Apr 16, 2023

Uh oh!

silversquirl commented Apr 17, 2023

Uh oh!

Techatrix commented Apr 17, 2023

Uh oh!

silversquirl commented Apr 17, 2023

Uh oh!

Techatrix commented Apr 17, 2023

Uh oh!

silversquirl commented Apr 17, 2023

Uh oh!

Techatrix commented Apr 17, 2023

Uh oh!

recursiveGecko commented May 1, 2023 •

edited

Loading

Uh oh!

neurocyte commented May 2, 2023

Uh oh!

bernardassan commented May 9, 2023

Uh oh!

Techatrix commented May 9, 2023

Uh oh!

bernardassan commented May 10, 2023

Uh oh!

leecannon commented May 30, 2023

Uh oh!

Techatrix commented Jun 11, 2023

Uh oh!

bernardassan commented Jun 12, 2023

Uh oh!

Uh oh!

Uh oh!

revive C import support #1136

revive C import support #1136

Uh oh!

Conversation

Techatrix commented Apr 16, 2023

Uh oh!

silversquirl commented Apr 17, 2023

Uh oh!

Techatrix commented Apr 17, 2023

Uh oh!

silversquirl commented Apr 17, 2023

Uh oh!

Techatrix commented Apr 17, 2023

Uh oh!

silversquirl commented Apr 17, 2023

Uh oh!

Techatrix commented Apr 17, 2023

Uh oh!

recursiveGecko commented May 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

neurocyte commented May 2, 2023

Uh oh!

bernardassan commented May 9, 2023

Uh oh!

Techatrix commented May 9, 2023

Uh oh!

bernardassan commented May 10, 2023

Uh oh!

leecannon commented May 30, 2023

Uh oh!

Techatrix commented Jun 11, 2023

Uh oh!

bernardassan commented Jun 12, 2023

Uh oh!

Uh oh!

recursiveGecko commented May 1, 2023 •

edited

Loading