Branching type resolution #1031
Conversation
bacd001 to
69072d3
Compare
const std = @import("std");
pub fn main() !void {
const t = std.os.system.dup(1);
_ = t;
}Hover over |
|
Hmm I can't seem to reproduce this... |
|
Looks like this might be a miscompilation, its fixed by removing return from pub fn getAllTypesWithHandlesArrayList(ty: TypeWithHandle, arena: std.mem.Allocator, all_types: *std.ArrayListUnmanaged(TypeWithHandle)) !void {
switch (ty.type.data) {
.pointer, .slice, .error_union, .other, .primitive => try all_types.append(arena, ty),
.either => |e| for (e) |i| try i.type_with_handle.getAllTypesWithHandlesArrayList(arena, all_types),
.array_index, .@"comptime" => {
// TODO
},
}
} |
|
wtf... nice find Lee! Also |
|
That works for me now, I absolutely love this feature! Something not required but would be nice, is showing the source of each declaration as while messing with this I immediately hit one where the types are different (although mostly compatible): |
75c2d5a to
4439d32
Compare
|
very exciting |
Tried implementing this but it's a bit of a hackfest, I think merging this now and then adding this later makes sense. I might take a jab at rewriting some analysis code so it's a bit less of a rats nest and try again. :) |
Finally, our mortal enemy has been defeated over the course of a stream. (shameless plug)
Resolve in signatureHelp(it's so hard 😭)