-
-
Notifications
You must be signed in to change notification settings - Fork 383
Embed AstGen into ZLS #1000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed AstGen into ZLS #1000
Conversation
I believe it should be |
Something that occurred to me after the multi-object-for change — Have you considered how the embedded ast-check would handle codebases meant to be compiled with older compiler versions? Theoretically, if ZLS (w/ embedded AstGen) gets compiled with |
zls master is only intended to really work with zig master, they update in lock-step. zls gets pinned in time for the zig releases to fix this exact problem. |
I know, but keeping build_runner.zig backwards compatible says otherwise 😀 |
We do try to keep the runtime zig version requirements as wide as possible by making sure the build runner can run on as many versions as possible but we only do this as a best effort. As @nullptrdevs points out the multi-object for is a breaking change to the language ( |
On its own, this PR does not make sense, but in the wider picture Techatrix painted in the Discord of using ZIR for analysis and eventually comptime interpreting, it absolutely does. I believe that for now, it would make the most sense to have |
777ec43
to
1067d5f
Compare
5ceb744
to
7761112
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been thinking this PR through and, at first I was a bit skeptical, but YOLO.
I guess we're getting closer and closer to becoming zig-analyzer
huh :P
This removes the dependency on Zig for showing
ast-check
diagnostics.This is also the starting pointer for integrating AstGen based analysis into ZLS.