Skip to content

Conversation

almmiko
Copy link
Contributor

@almmiko almmiko commented Sep 23, 2023

Adds completions_with_replace flag to determine replace behavior.

Fixes: #1235

Copy link
Member

@SuperAuguste SuperAuguste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this as this is a good compromise, but in the future, we'd like to review how we do completion replacement in a manner acceptable for all so a flag like this may not be necessary.

@SuperAuguste SuperAuguste merged commit de2464a into zigtools:master Oct 1, 2023
KoltPenny pushed a commit to KoltPenny/zls that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zig confirm suggestion "replace" instead of "insert"
2 participants