Skip to content

Problem: atexit does not work when building a Windows DLL #1608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 20, 2017
Merged

Problem: atexit does not work when building a Windows DLL #1608

merged 3 commits into from
Jan 20, 2017

Conversation

bluca
Copy link
Member

@bluca bluca commented Jan 19, 2017

Solution: put more emphasis in the docs, and call zsys_shutdown from each selftest when building on Windows

bluca added 3 commits January 19, 2017 21:43
@bluca
Problem: Windows DLL builds can't use atexit
8f8aa86 
Solution: run zsys_shutdown at the end of each selftest
@bluca
Problem: zsys_shutdown doc not very clear about DLL
051370d 
Solution: tell the users explicitly to call zsys_shutdown manually
when building CZMQ as a DLL on Windows.
@bluca
Problem: README.md out of date with documentation
d77bfc5 
Solution: update it
@bluca bluca mentioned this pull request Jan 19, 2017
Closed
@bbdb68 bbdb68 mentioned this pull request Jan 20, 2017
Closed
@bluca
Copy link
Member Author

bluca commented Jan 20, 2017

@sappo ping

@sappo sappo merged commit 4af97ee into zeromq:master Jan 20, 2017
@sappo
Copy link
Member

sappo commented Jan 20, 2017

Sorry

@bluca bluca deleted the zsys_shutdown branch January 20, 2017 20:42
@bluca
Copy link
Member Author

bluca commented Jan 20, 2017

Thanks! No worries

@bluca bluca mentioned this pull request Jun 13, 2017
Closed
@bluca bluca mentioned this pull request Aug 31, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bluca @sappo