Skip to content

Conversation

devvick
Copy link
Contributor

@devvick devvick commented Jun 11, 2021

I've redefined the systemd unit files to conform with "best practices":

  1. Timer units shouldn't have dependencies.
  2. .service unit run by a timer shouldn't be installable (it's supposed to run periodically, not as a service)
  3. Persistent= directive is useful only with Realtime timer, not Monotonic, as used here.

More reading:
https://wiki.archlinux.org/title/Systemd/Timers#Examples

@erikh
Copy link
Contributor

erikh commented Jun 14, 2021

LGTM; just waiting on a response to my comment, assuming's fine I'll merge and release.

@erikh
Copy link
Contributor

erikh commented Jun 15, 2021

ok between this and the changes I merged earlier into zeronsd, we've got a really great systemd story on our hands now. Thanks to both of you for helping me finagle this.

@erikh erikh merged commit 6432472 into zerotier:main Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants