Skip to content

Fixes: missing containerPort not detected #416 #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 8, 2022
Merged

Fixes: missing containerPort not detected #416 #431

merged 4 commits into from
Feb 8, 2022

Conversation

kmarteaux
Copy link
Contributor 

RELNOTE: Implements an optional Pod container ports test. Checks to ensure a ports containerPort value isn't missing and name ports are unique.

zegl
zegl approved these changes Feb 8, 2022
View reviewed changes
Copy link
Owner

@zegl zegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool! Thanks! 👍

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 8, 2022

Build succeeded:

@bors bors bot merged commit 4922190 into zegl:master Feb 8, 2022
@kmarteaux kmarteaux deleted the feature/container-ports branch February 8, 2022 18:43
@kmarteaux kmarteaux mentioned this pull request Feb 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zegl zegl zegl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmarteaux @zegl