Feature #413: container ephemeral storage request and limit check #429
Conversation
kmarteaux
commented
Feb 3, 2022
…resource request and limit
…eral-storage resource request and limit
…eral-storage resource request and limit
|
Refactored the original implementation - moved the new checks to score/container.go and the associated tests to score/score_test.go. Split the resource checks into default (are they set) and optional (are they equal) as previously recommended. Removed the separate score/ephemeralstorage/ephemeralstorage.go and score/ephemeralstorage_test.go files. Updated score.go to remove ref to deleted files. |
|
|
||
| func TestPodContainerStorageEphemeralNoRequest(t *testing.T) { | ||
| t.Parallel() | ||
| testExpectedScore(t, "pod-ephemeral-storage-missing-request.yaml", "Container Ephemeral Storage Request and Limit", scorecard.GradeWarning) |
There was a problem hiding this comment.
Could we have a test that checks for "Container Ephemeral Storage Request and Limit" returning GradeAllOK?
There was a problem hiding this comment.
Additional test case (GradeAllOK) added.
|
Thanks! Looks great 👍 , there's just one test case (the happy path) that isn't tested. Update the PR with that, and we're ready to ship! |
…orage Request and Limit' returning GradeAllOK
|
Build succeeded: |