Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: zclconf/go-cty
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.13.0
Choose a base ref
...
head repository: zclconf/go-cty
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.13.1
Choose a head ref
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Mar 16, 2023

  1. function: Don't call function Impl if we didn't call Type 

    By default cty function calls "short circuit" -- skip calling the Type
function and just immediately return cty.DynamicPseudoType -- if any of
the arguments are cty.DynamicVal.

However, in that case we were previously only skipping the call to Type
but yet still expecting Impl to be able to run. That's incorrect because
Impl functions should be able to treat Type as a "guard" and be guaranteed
that Impl will never run if Type failed.

To fix that hole we'll now track whether we skipped calling Type, and if
so we'll also skip calling Impl and just immediately return an unknown
value. Individual functions can still opt out of this behavior by
declaring on or more of their parameters as AllowDynamicType: true, in
which case their own Type function will get to decide how to handle that
situation.
    @apparentlymart
    apparentlymart committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    e9ad14f View commit details
    Browse the repository at this point in the history

  2. Release v1.13.1

    @apparentlymart
    apparentlymart committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    180e0b5 View commit details
    Browse the repository at this point in the history
Loading