-
-
Notifications
You must be signed in to change notification settings - Fork 29
feat: Search via URL - Add q and qd parameters #988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Regression bugs:
|
bugs should be fixed. |
Wow, great that you tried AI coding. Overall it looks good, i have to take a closer look on desktop. I tried once Github copilot AI coding, but i wasnt patient enough to pass over the issues, since it was easier to do it myself 😃 |
I tried to untangle the code for less than an hour, but it is too hard :) The issue is, that current code is already getting old, and it needs some urgent refactorings (like "await fetchGeocoderOptions" which in turn could be called directly from "qd" useEffect). Of course, the AI also makes some unnecessary changes like removing comments, moving inputRef outside for no reason etc, but these quite easy to revert. The architecture though is harder. Merging code like this would make any further refactorings impossible. I have already seen it in companies I worked for – the product team forces some features, there is no time for proper refactoring and the code debt becomes unmanageable. Though, the good point is that I had to go over the SearchBox code and i see more clearly where are the issues. 🙂 🤞 Also thanks for testing the Cursor AI for me, it is intriguing to see how it works. (And where it doesn't work well) ❤️ |
Yeah, thanks to look into that. I expected something like this. Hope you find time to refactor it, soon :-) |
@zbycz I noticed you started the refactoring. Very nice. 👍👀👍 |
@amenk - yep, i am already polishing the And also - I have to admit, that I used part of this PR as a reference. It was much easier for me to imagine how it all should work, because I had the glimpse of verbose-but-working solution. So - if you ever needed some new feature in OsmAPP, using cursor to make a prototype is a good idea after all! 👍🙂 |
Description
See #119
Disclaimer: I did this with cursor AI - feel free to discard completely.
Mainly doing the MR to have some PoC Vercel app for further testing.
Example links
Screenshots
Checklist