Skip to content

general: get rid of catchall route #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 26, 2025
Merged

general: get rid of catchall route #979

merged 16 commits into from
Mar 26, 2025

Conversation

zbycz
Copy link
Owner

@zbycz zbycz commented Mar 20, 2025

In this PR:

  • get rid of catchall [[...all]] route in the root Get rid of catchall route #800
  • all urls like coords feature (/50.1,14.1) and shortener (/xyzn) are kept, see rewrites in next.config.mjs
  • Experiment: add static 404, which is routed by CDN itself, without the need for paid "function invocation"
    • lets see if this makes any difference :-) then switch off this experiment.
    • It works only for HTTP request to Vercel, on dev/while clicking in APP, the internal 404 may be rendered
    • WARNING: unfortunately I wasn't able to send HTTP status 404, so the page just have meta-equiv=noindex to prevent bots from indexing it

Expectation

All these red-marked paths should disappear from umami logs of "SSR requested paths". For last 30 days it means 20% out of 79k tracked SSRs. I still wonder where are the 800k function invocation reported by vercel. Lets see if it moves down also by 20%.

Untitled

Copy link

vercel bot commented Mar 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
osmapp ✅ Ready (Inspect) Visit Preview Mar 26, 2025 1:00pm

Copy link

vercel bot commented Mar 24, 2025

Deployment failed with the following error:

Rewrite at index 0 has invalid `source` pattern "/(?!node)".

Learn More: https://vercel.link/invalid-route-source-pattern

@zbycz zbycz marked this pull request as ready for review March 26, 2025 12:40
@zbycz zbycz merged commit 49d0474 into master Mar 26, 2025
4 checks passed
@zbycz zbycz deleted the catchall branch March 26, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant