The latest updates on your projects. Learn more about Vercel for Git ↗︎

@govvin and @jvaclavik what do you think?
Here is the preview deployment

I like it very much!
I have a few thoughts:

• buttons have no on touch state and sometimes it selected text of the button, but both can be fixed by using mui chips

• there is a bug when quick buttons doesn't fit properly and you can't scroll. It's cut
  

• i was really confused by osmapp in icon buttons. It's just share not a link. Below i suggest solution

• i think apple maps are too prominent, suggesting move them next to google maps 👮‍♀️😂

• icons for external link and share in icon button in sharing dialog should be after the text. It will look better. In list it's correct

• do we need image attribution? And if yes, i suggest to make it smaller, without bold, with secondary color and some margin top. User doesn't need it and it's very prominent. - i tested it only on mobile, not sure what's the behaviour of share on desktop

• one idea to consider: maybe tabs should include also icon buttons. In this case we could show different content so osmapp would fit there. In this case i suggest to show share tab first and osmapp should have the first position

• Also I'm not sure if we need all the duplicity links there between the list and icon buttons. But we can update it later.

• What about rename sections to:
  Link -> Open in
  Share -> Share a link (this should be default and the first tab IMHO)

Good job @Dlurak 🥳! I really like changes you are making in your PRs.

• I've migrated to mui chips
• Fixed the scrolling bug
• I moved apple maps behind google maps
• The icon is now behind the label
• I'm not sure but I think we need the attribution, it was indeed very prominent I made it smaller and in a secondary color
• I've renamed the tabs, added German translations and included icons
• The default is now sharing except when the webshare api isn't available then the links are the default

I'm not sure if moving the icon buttons into the tab views would be a really good idea.

Awesome job @Dlurak ! 🎉 Thank you.

Some thoughts:

• Tabview labels
  • User-friendly labels are desirable. "GeoURI" is not a familiar term for most people. How about: "Native App", "Open in App" or "Open in Device",
    • Maybe it needs a better icon, for example, something similar to this ?
  • the icons look too big (IMO), and if we choose the right icon, the labels below them should be unnecessary. Only first 3 icons are visible, and the rest is accessible by scrolling first (is that a behavior we want?, when same option is already listed below.
  • Smaller icons, without labels, can fit 4-5 items without the need to scroll.
• Attribution
  • The attribution doesn't have to be in that window. You can follow attribution requirements by including it in the main attribution (lower right corner of the main map.) In addition, the "i" button also mention where the specific image came from. ( i noticed a bug: if a tap the "i" button and close the drawer, the attribution still shows on the map)
• URLs from tags in FeaturePanel (probably unrelated to this PR)
  • when opening URLs, would it not be better to open them in new windows instead ?

The smaller and gray attribution doesn't really cause any optical clutter
And the urls aren't related to this issue.

• I agree that the label "GeoURI" isn't ideal, but longer labels like "Open In App" aren't feasible due to the limited spaced. Do you maybe have a short label idea?
• The icon you proposed looks nice we can try it out :)

I did some quick experimentation for smaller icons and here is the result:

Smaller icons allow more options to fit without scrolling, which is a positive change. However, I believe the larger icons looked better visually and added clarity by allowing labels and icons that indicate link vs. share actions. Without these, users may struggle to differentiate services, particularly with the less intuitive GeoURI icon.

@govvin what do you think of this new icon and label?

Hi @Dlurak,
We were discussing dialog ux with @zbycz and we created following wireframe:

We were thinking that current design is a too complex for the user and we could simplify it a bit.
User has usually 3 use cases when he clicks to this button:

1. Copy current URL to clipboard or share it on mobile with sharing dialog
2. Get coordinates (in various formats)
3. Open in different app

Few thoughts:

• We agreed that it's not necessary to provide sharing dialog for all external apps.
• link is in read only MUI Textfield component and you can copy or manually or with button. Also on mobile there is a share button for native dialog. When you check shorten link it shorten format of the link (we have it already)
• coordinates are similar like link but it's a MUI Select component where you can choose from multiple GPS formats (decimals vs degrees, etc.). You can copy or share it same way as in link section.
• open in ... shows items in MUI List. First 3-4 will have icons, other one's shouldn't have it. When you click on it it opens it in external window/app but you can't share it in the native share dialog (design would be too cluttered). Also geouri should be another item in the list here.

What do you think about it?

Something like this?

I think the new repo location broke preview deployments.

Overall I am happy with the code and the design as well, if you @govvin and @jvaclavik don't have any suggestions anymore I think we can merge it

Something like this?

Love it, ship it 👌

Btw input field in link could be with the same size as select if possible.

Could you please try to run again the deployment? For example just amend commit and force push. It should work again

Both parts are now equally high and preview deployments work again, I'm gonna merge this 🎉

@govvin what do you think of this new icon and label?

@Dlurak , I wonder if you can use the icon and label for GeoURI in the revised feature panel, since you're using logos anyway? "Map App" is definitely more intuitive. 👍

In my opinion, it should be the first option since it ought to work natively in their device, followed by OSM, Mapy.cz and then Google. 😄

The new feature panel looks great, and straight-forward.