Skip to content

Add Japanese language #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Add Japanese language #722

wants to merge 3 commits into from

Conversation

j9d3it
Copy link
Contributor

@j9d3it j9d3it commented Nov 1, 2024

I'd like to contribute a Japanese translation. edit: very glad for these automatic Vercel deploys.

Copy link

vercel bot commented Nov 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
osmapp ✅ Ready (Inspect) Visit Preview Nov 1, 2024 7:39am

found an errant Japanese comma at the end
add Japanese
@j9d3it j9d3it marked this pull request as ready for review November 1, 2024 07:51
@j9d3it
Copy link
Contributor Author

j9d3it commented Nov 1, 2024

Not sure about that yarn prettier thing...

Also, I want to have it show the default name= value instead of the transliterated ones in Japan, how would I do that?

@Dlurak
Copy link
Collaborator

Dlurak commented Nov 1, 2024

Awesome contribution, I really love it!
Either I can't push to this pull request or I didn't figure out how so I will just explain the prettier stuff:

  1. If you use nix you can enter a nix-shell with nix develop to get all dependencies
  2. If you are a web developer you probably have nodejs and yarn installed anyways.
  3. If not you can use a github codespace they have it installed.
  4. After opening the code in a github codespace you can go to the terminal and run nvm use 20 this will make sure you use the correct version of nodejs
  5. Then you need to install the JavaScript dependencies with this command: yarn this can take a while but shouldn't be too long on a codespace
  6. Now you can run yarn prettify this formats the code to our standards
  7. Commit and push

I hope my explanation is understandable, feel free to ask for more assistance


Also, I want to have it show the default name= value instead of the transliterated ones in Japan, how would I do that?

What's the problem and difference, I took a look on the preview deployment and all the Japanese places used Japanese labels?

@j9d3it
Copy link
Contributor Author

j9d3it commented Nov 1, 2024

Awesome contribution, I really love it! Either I can't push to this pull request or I didn't figure out how so I will just explain the prettier stuff:

1. If you use nix you can enter a nix-shell with `nix develop` to get all dependencies

2. If you are a web developer you probably have nodejs and yarn installed anyways.

3. If not you can use a github codespace they have it installed.

4. After opening the code in a github codespace you can go to the terminal and run `nvm use 20` this will make sure you use the correct version of nodejs

5. Then you need to install the JavaScript dependencies with this command: `yarn` this can take a while but shouldn't be too long on a codespace

6. Now you can run `yarn prettify` this formats the code to our standards

7. Commit and push

I hope my explanation is understandable, feel free to ask for more assistance

I am not a developer so I will just wait until you guys support another way of contributing translations.

@j9d3it j9d3it closed this Nov 1, 2024
@j9d3it
Copy link
Contributor Author

j9d3it commented Nov 1, 2024

ja.js.json

Just rename this to ja.js and try it yourself, and make sure to add Japanese to the config.mjs file.

@Dlurak
Copy link
Collaborator

Dlurak commented Nov 1, 2024

For a long time we already want to support an easier way to add translations

I've created the pull request #725

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants