FeaturePanel: Single public transport route #626
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
810bb76 to
ad7d75a
Compare
|
Wow, good idea. This looks wonderful! 😻 One design idea though, instead of the checkbox above, we could add toggle button right after the first stop, eg like this. What do you think? |
| background: isFirst ? 'transparent' : color, | ||
| }} | ||
| /> | ||
| {hold && ( |
There was a problem hiding this comment.
I don't understand what does this prop mean, can you please explain and then we can perhaps find a more suitable name?
There was a problem hiding this comment.
At all stations a train holds so they get a circle on the left line. The show more/show less buttons should not get that circle as a train doesn't hold there.
hold shows/hides that circle:
There was a problem hiding this comment.
Maybe we should just call it showCircle or something similar. This names indicates what the property is for
| return ( | ||
| <StationsList> | ||
| {stops.map((stop, i) => { | ||
| {stopsWithButton.map((stop, i) => { |
There was a problem hiding this comment.
While this is better than before, I would suggest code like this - in my opinion it is more streamlined, it doesnt mix stops with buttons. Also we could get rid of the showCircle prop, or just use it statically.
stops.map((stop, i) => (
<>
<StationItem stop={stop} showCircle />
{i === 0 ? (<ShowMoreLessButton />) : null}
</>
))
Do you think this could work, or do I miss something?
There was a problem hiding this comment.
ShowMoreLessButton needs to be in a own StationItem. If it isn't in one at all the left line will suddenly stop and then start again. If it is in the same as the Link it will break the spacing and the circle would be shown in between the button and the first label. If you can think of a solution better then the one I just commited let me know :)
There was a problem hiding this comment.
Sure, that was only a pseudo-code.
The solution you commited is perfect i think. We get rid of the stopsWithButton array, and the code reads clearly now. 👍
|
I noticed you recently prefixed a pr with |
I think |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Description
When the user clicks a single public transport route they now can see a list of stops.
If the route has more then 7 stops it will get minimized in a smaller view. It is easy to expand it back either by using the checkbox or by pressing the small arrow.
Example links
/relation/13065547
Screenshots