Skip to content

Map: Use localized names #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2024
Merged

Map: Use localized names #607

merged 1 commit into from
Oct 7, 2024

Conversation

amenk
Copy link
Contributor

@amenk amenk commented Sep 30, 2024 •
edited by zbycz
Loading

Fixes #460

Show the map in the selected app-language.

Amharic

Screenshot from 2024-09-30 20-48-55

Spanish

Screenshot from 2024-09-30 20-48-41

Checklist

  • checked dark mode / light mode
  • checked mobile / desktop
  • checked server-side-rendering (SSR)
  • code style is consistent with the rest of the project
  • [] new dependencies are reasoned about in PR comments

@vercel Vercel
Copy link

vercel bot commented Sep 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
osmapp ✅ Ready (Inspect) Visit Preview Sep 30, 2024 6:55pm

@zbycz zbycz mentioned this pull request Oct 7, 2024
Merged
@zbycz zbycz changed the title #460 Language switcher Map: Use localized names Oct 7, 2024
zbycz
zbycz approved these changes Oct 7, 2024
View reviewed changes
Copy link
Owner

@zbycz zbycz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, in combination with #608 we will have finally completely localized names! 🎉

btw, thanks also for your generous donation to OsmAPP 😊

@zbycz zbycz merged commit d36528f into zbycz:master Oct 7, 2024
2 checks passed
@zbycz
Copy link
Owner

zbycz commented Oct 7, 2024 •
edited
Loading

Now as I see it, it feels that we should always show the "name" in Map, along with "name:{lang}". When I open the map in Czech i see a lot of translated cities in neighbor countries which are not usually know by the translated name at all.

Do you have this issue as well?

Discussion here:

@zbycz zbycz mentioned this pull request Oct 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbycz zbycz zbycz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use localized names in map
2 participants
@amenk @zbycz