Skip to content

LayerSwitcher: Add an explaination to the custom url option #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 17, 2024
Merged

LayerSwitcher: Add an explaination to the custom url option #535

merged 4 commits into from
Sep 17, 2024

Conversation

Dlurak
Copy link
Collaborator

@Dlurak Dlurak commented Sep 10, 2024

Description

Fix #530 by adding a dynamic explaination to the user
image

Checklist

  • checked dark mode / light mode
  • checked mobile / desktop
  • checked server-side-rendering (SSR)
  • code style is consistent with the rest of the project
  • new dependencies are reasoned about in PR comments

@vercel Vercel
Copy link

vercel bot commented Sep 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
osmapp ✅ Ready (Inspect) Visit Preview Sep 17, 2024 2:43pm

zbycz
zbycz previously approved these changes Sep 11, 2024
View reviewed changes
Copy link
Owner

@zbycz zbycz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes! Just a few ideas.

@zbycz
Copy link
Owner

zbycz commented Sep 11, 2024

Also please prefix the title of this PR with LayerSwitcher: before you merge it 🙏

It helps me in creating changelog after a release. Thx

@Dlurak Dlurak changed the title Add an explaination to the custom url option of the layer switcher LayerSwitcher: Add an explaination to the custom url option Sep 12, 2024
zbycz
zbycz approved these changes Sep 17, 2024
View reviewed changes
Copy link
Owner

@zbycz zbycz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, feel free to merge 👍

@Dlurak Dlurak enabled auto-merge (squash) September 17, 2024 14:40
@Dlurak Dlurak merged commit e07e007 into zbycz:master Sep 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbycz zbycz zbycz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom layer parameters missing
2 participants
@Dlurak @zbycz