The latest updates on your projects. Learn more about Vercel for Git ↗︎

Great fix, very welcomed :) thanks 🙂

I feel we need some more tests to this whole id-tagging-scheme integration. I think this worked some time before, but it is easy to break anything :) -> #573

It is easy to break anything

About that, it seems like I've broken something: Schools. It is definitely very fragile and we need more tests

I will investigate the problem later this day

I don't see an issue eg here https://osmapp.org/way/318017486

It was very hard and experimential to build it in the first place. With current knowledge I know much better how I want to use it. I do some refactors in #506 - I will try to add some tests along.

It seems to work on some schools, but this one doesn't work: https://osmapp.org/way/194819147

And there are way more that don't work

Ok so the problem is that the internationalized value is undefined when there is a tag contact:email without a tag email.
The computed key is email so it tries to get the value as tags['email'] which doesn't exist as there is only a contact:email so the value becomes undefined which then fails in the function that returns a url for a tag as you can't do v.match when v is undefined.
I hope it is clear what i mean.
This is how the field looks:

email: {
    key: 'email',
    keys: [ 'email', 'contact:email' ],
    type: 'email',
    fieldKey: 'email'
  }

@zbycz I think I have a fix! are you working on a refactoring or should I open a new pr?

I think i get what you might mean. That if there is no translation in fieldTranslations, then it fails?

Feel free to fix it. I will work on #506 probably next week, so i will rebase on master.