FeaturePanel: Implement a table for airport runways #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zbycz
requested changes
Jul 23, 2024
|
@zbycz I think it is fine now. I've addressed your reviews and the merge conflicts |
…lurak/airport-runways # Conflicts: # yarn.lock
|
Thanks for you contribution, looks perfect. Merging. I added few more edits, please see those commits to know what is preffered codestyle in future PRs. If unsure, feel free to comment 🙂 |
zbycz
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #408
Examples:
Using overpass the runways are fetched. If there is at least one they are shown in a table. If at least one size is known it is also shown in the table.
Here are some screenshots:
This fixes #408