The latest updates on your projects. Learn more about Vercel for Git ↗︎

I think it would have been better if I've opened a new pr for showing the routes on the map, sorry about that

Related issue: #538

@Dlurak Are you going to finish this one? I really like how you showing railroads on the map ❤️

Oh of course, sorry I just forgot about it. Probably this evening or tommorow

Now the code fetches the master relations which can't be directly displayed on the map. I will fix this later

The routes aren't shown on the map in a server rendered environment because getGlobalMap returns undefined. But else it should be ready @zbycz

The routes aren't shown on the map in a server rendered environment because getGlobalMap returns undefined. But else it should be ready @zbycz

It works for me fine. In SSR there will never be any useEffect nor ReactQuery fired anyway. I think it is better to let SSR only handle main part of FeaturePanel and let this PublicTransport component be rendered only on client – there the map exists ok, right?

This will be even better once we finish #214, so people can click a (master) route and see its outline as well. Feel free to take it if you want.

Wow, this is pretty cool. But I am not sure if we should show all the routes by default on the map.
For example https://osmapp.org/node/2470201868#8.48/48.4996/12.3864 marks half of Germany / even Europe red ;-)

Would it make more sense

1. to use a similar method for relation display (i.e. when clicking a route https://osmapp.org/relation/17329553#17.00/48.3443/11.8086)

2. to eventually let the user toggle routes or group of routes (all regional trains for example) if they want to display multiple routes? (there still could be an "all" button to have the behavior as it is in the moment)

to eventually let the user toggle routes or group of routes (all regional trains for example)

I absolutely love that idea! Designwise I am quite unsure how to do it. @zbycz do you maybe have an idea?

I absolutely love that idea! Designwise I am quite unsure how to do it.

I think the query should be split in two, first one "quick" would only download the data needed for the PublicTransportDisplay component.

There below it could be a toggle (eg https://mui.com/material-ui/react-switch/ + "Show routes on map") which would load the geometry request which can take longer time ~ 10 MB.

@amenk your second idea is implemented and deployed on OsmAPP.
The first one relies on #214