Skip to content

Vocab changes and styling fix for overbearing parks #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 30, 2023

Conversation

Flohhhhh
Copy link
Contributor

@Flohhhhh Flohhhhh commented Jan 19, 2023

Fixed #40, village names now have more priority than park names.
image

I adjusted some of the English wording to sound more natural. Also addresses #96
image
image

@vercel
Copy link

vercel bot commented Jan 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
osmapp ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 30, 2023 at 8:40AM (UTC)

@zbycz
Copy link
Owner

zbycz commented Jan 19, 2023

Hi, thanks for so much activity today! I will go through it probably tomorrow afternoon (UCT) 😉

Added new ``.note_button`` field for use when user is not logged in.
Changed ``.edit_button`` field for use when user is logged in for edits.
Copy link
Owner

@zbycz zbycz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have few point to discuss in the comments, but overall i like it. I would merge the Styles changes right away, but Vocabulary.js needs some iterations :)

@Flohhhhh
Copy link
Contributor Author

I really can't tell what prettier isn't liking, I'll have to take a closer look later

@zbycz
Copy link
Owner

zbycz commented Jan 25, 2023

@Flohhhhh Dont worry about prettier, i will run all through autofix. I need to add the plus icon as well. Probably in evening.

@zbycz
Copy link
Owner

zbycz commented Jan 30, 2023

Plus icon is done and all is deployed to the main URL. Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Names of villages are sometimes hidden even though there is whole village visible
2 participants