Skip to content

Public transport labels enhancments #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from

Conversation

Dlurak
Copy link
Collaborator

@Dlurak Dlurak commented Sep 1, 2023

@kudlav found two issues with the Public transport labels.

  1. When a routes color is stored as normal English word e.g. yellow the text color can't be correctly set to white or black and the contrast may be low, as suggested now the words get mapped to a hex value.
  2. With bus, tram... stops nearer than 150 meters from each other the routes from the other one will be shown. Now the name of the stop position must be the same as from the station.
    I've explained why this may become a problem here

@vercel
Copy link

vercel bot commented Sep 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
osmapp ✅ Ready (Inspect) Visit Preview Sep 10, 2023 6:34pm

@Dlurak Dlurak mentioned this pull request Sep 1, 2023
@zbycz
Copy link
Owner

zbycz commented Sep 10, 2023

HI @Dlurak, i merged master to this PR and it appears it has no code in it. Also it has 10 commits the same as #175.

Can you please push the code again? Perhaps trying to rebase on current master branch?

If it is a pain, feel free to close this PR and open a new one. Thx :)

@Dlurak
Copy link
Collaborator Author

Dlurak commented Sep 23, 2023

Sorry for the inconvenience but I just opened a new PR which addresses these issues.

@Dlurak Dlurak closed this Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants