Skip to content

fix(mirror): separate artifact upload by component #3980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 10, 2025
Merged

fix(mirror): separate artifact upload by component #3980

merged 9 commits into from
Jul 10, 2025

Conversation

AustinAbro321
Copy link
Contributor

@AustinAbro321 AustinAbro321 commented Jul 10, 2025 •
edited
Loading

Description

Adds an option to ImagePushOptions and RepoPushOptions, Remove and Deploy for the user to list components. Fixes #3964 where deploy was passing every component to both mirror resources. Additionally, automatically filters Remove and Deploy by localOS.

Checklist before merging

brandtkeller and others added 3 commits July 3, 2025 15:45
@brandtkeller
fix(mirror): separate artifact upload by component
3b7ea2c 
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
@brandtkeller
chore(docs): update comments to reflect accuracy of artifact upload
fa34309 
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
@AustinAbro321
filter and accept components
80c5f5b 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@netlify Netlify
Copy link

netlify bot commented Jul 10, 2025 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit a269daa
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/686fcee09b24a70008b16246

@AustinAbro321 AustinAbro321 changed the title fix: filter components for mirror, deploy, and remove SDK functions fix!: filter components for mirror, deploy, and remove SDK functions Jul 10, 2025
@AustinAbro321
update comment
1f5a101 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321 AustinAbro321 marked this pull request as ready for review July 10, 2025 12:53
@AustinAbro321 AustinAbro321 requested review from a team as code owners July 10, 2025 12:53
@AustinAbro321
Merge branch 'main' into filter-and-accept-components
6e0c5a0
@AustinAbro321
fix lint
491fcb7 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Jul 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 87 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/packager/mirror.go 0.00% 53 Missing ⚠️
src/pkg/packager/deploy.go 0.00% 26 Missing ⚠️
src/pkg/packager/remove.go 0.00% 5 Missing ⚠️
src/internal/packager/images/push.go 0.00% 2 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
src/internal/packager/images/push.go 52.28% <0.00%> (-0.81%) ⬇️
src/pkg/packager/remove.go 0.00% <0.00%> (ø)
src/pkg/packager/deploy.go 0.00% <0.00%> (ø)
src/pkg/packager/mirror.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AustinAbro321
remove filters
75ffa30 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321 AustinAbro321 changed the title fix!: filter components for mirror, deploy, and remove SDK functions fix(mirror): separate artifact upload by component Jul 10, 2025
@AustinAbro321
optional components
9c5a72d 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321
update message
a269daa 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
brandtkeller
brandtkeller approved these changes Jul 10, 2025
View reviewed changes
Copy link
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Jul 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 10, 2025
@brandtkeller brandtkeller added this pull request to the merge queue Jul 10, 2025
@brandtkeller brandtkeller mentioned this pull request Jul 10, 2025
Closed
2 tasks
Merged via the queue into main with commit 6923fad Jul 10, 2025
28 of 29 checks passed
@brandtkeller brandtkeller deleted the filter-and-accept-components branch July 10, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtkeller brandtkeller brandtkeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When deploying multiple components with only images, they are uploaded multiple times
2 participants
@AustinAbro321 @brandtkeller