feat: track progress on image pull/push #3904
Conversation
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
✅ Deploy Preview for zarf-docs canceled.
|
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Codecov ReportAttention: Patch coverage is
... and 14 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
src/internal/packager/images/pull.go
Outdated
There was a problem hiding this comment.
It's easier to review this with whitespace hidden
| const defaultProgressInterval = 5 * time.Second | ||
|
|
||
| // StartReporting starts the reporting goroutine | ||
| func (tt *TrackedTarget) StartReporting() { |
There was a problem hiding this comment.
Given that the push is governed by the caller-supplied context - I wonder if this should accept context and if we could remove more of the bespoke stopReports in favor of a ctx.Done()
There was a problem hiding this comment.
Yeah it should definitely accept a context. Though to get rid of the StopReporting call we'd have to make a separate context for StartReporting then cancel it. I like the feel of the defer StopReporting slightly more, but I don't feel too strongly either way
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
|
@brandtkeller Separated out the Tracker object and created a unit test for it. I wanted to avoid creating a registry or mocking an |
| ) | ||
|
|
||
| // newTestTracker creates a Tracker instance with a customizable report interval for testing. | ||
| func newTestTracker(bytesRead, totalBytes int64, reporter Report, interval time.Duration) *Tracker { |
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Description
This introduces occasional log statements to give progress during OCI pulls and pushes (images and Zarf packages).
Implementation was loosely inspired by the progressbar implementation in the ORAS CLI. Goal was to create simple a simple solution that avoids leaving users without feedback from the system for more than five seconds. UX was designed to be similar to how opentofu gives occasional progress feedback when something takes a while.
Views:
image pull on create:
image push on deploy (lowered interval for screenshot because local pushes are fast):
package pull:
package publish:
Related Issue
Fixes #3633
Checklist before merging