Skip to content

Conversation

nick-adkins
Copy link
Contributor

Second attempt at adding contributor ladder. Closing previous PR #4006 to maintain clarity.

Related Issue #2250

Description

...

Related Issue

Fixes #

Relates to #

Checklist before merging

Second attempt at adding contributor ladder. Closing previous PR #4006 to maintain clarity.

## Related Issue #2250 

Signed-off-by: nick-adkins <nick@defenseunicorns.com>
@nick-adkins nick-adkins requested review from a team as code owners August 21, 2025 21:35
Copy link

netlify bot commented Aug 21, 2025

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit eb62ce7
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/68b72a32b5c2f400085b436d

@nick-adkins nick-adkins mentioned this pull request Aug 21, 2025
2 tasks
Copy link
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documenting maintainer requirements for posterity


**Defined by:** Member of the Zarf GitHub ["Maintainer" team](https://github.com/orgs/zarf-dev/teams/maintainers).

#### Responsibilities
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be curious about removing the Pre-requisites section and rather leaning into Responsibilities as a "Demonstrates meeting the responsibilities of a maintainer"

brainstorming potential requirements:

## Quantitative

1. Contribution History - sustained contribution over time (typically 6-12 months and some number of significant PRs)
2. Issue Triage - Reviewed, Closed or managed responsibly
3. Code Review - healthy balance of submitted reviews to submitted PRs
4. Camp Cleanliness - generally leaves the state cleaner than before
5. Responsiveness - responds to PRs and issues in a timely manner

## Qualitative

1. Technical Judgement - demonstrates a deep understanding of the project
2. Communication - respectful and constructive in reviews and discussions
3. Initiative - takes ownership of the project and actively participates
4. Reliability - consistent and transparent about bandwidth and limitations
5. Decision Making - makes good decisions about the project and its direction

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Qualitative

  1. Contribution History - sustained contribution over time (typically 6-12 months and some number of significant PRs)

Added to pre-reqs; refined to 12-month time period & 10 PRs.

  1. Issue Triage - Reviewed, Closed or managed responsibly.

Added to responsibilities: Issue Triage; added quantities; added 10x issues/week

  1. Code Review - healthy balance of submitted reviews to submitted PRs

Added to responsibilities: Project control quality; added 1:1 ratio

  1. Camp Cleanliness - generally leaves the state cleaner than before

Added to B. - how to quantify?

  1. Responsiveness - responds to PRs and issues in a timely manner

Adjusted E. - how to set achievable goals?

Quantitative

  1. Technical Judgement - demonstrates a deep understanding of the project

Adjusted A.

  1. Communication - respectful and constructive in reviews and discussions

These are general expectations for all members of the project. Need to state in "Community Members" responsibilities or is it adequately subsumed under OpenSSF expectations?

  1. Initiative - takes ownership of the project and actively participates

Moved to responsibilities "C"

  1. Reliability - consistent and transparent about bandwidth and limitations

Moved to responsibilities "D"

  1. Decision Making - makes good decisions about the project and its direction

adequately covered under "A"?

Copy link
Contributor Author

@nick-adkins nick-adkins Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New Draft:

#### Responsibilities

- A. Technical Judgement - Demonstrate a deep understanding of the project and sound technical judgment
- B. [From Brainstorming] Camp Cleanliness - generally leave the state cleaner than before [Added - possible to quantify?]
- C. [From Brainstorming] Initiative - take ownership of the project and actively participate
	- C1. Participate in OpenSSF or Zarf-specific community meetings, if possible
	- C2. Facilitate  Zarf-specific community meetings, if possible
	- C3. Mentor contributors and reviewers
- D. [From Brainstorming] Reliable - consistent and transparent about bandwidth and limitations
- E. [From Brainstorming] Responsive - respond to PRs and issues in a timely manner.  [Set quantitative goals?]
- F. Quality Control - Maintain project quality control via code reviews
	- F1. [From brainstorming] Maintain healthy balance (~1:1) of submitted reviews to submitted PRs to enable project code collaboration
	- F2. Approve and merge code contributions as appropriate [Moved from Responsibilities "E"]
- G. [From Brainstorming] Issue Triage - Responsibly review, close, or manage issues in the backlog: minimum 10x issues per week



#### Pre-requisites

- I. [From Brainstorming] Demonstrates the principles and responsibilities required for qualitative Maintainer Responsibilities
- I. [From Brainstorming] Sustained contribution history over 12 month time period and 10+ significant PRs.
- II. Reviewer for at least 1 month
- III. Reviewed at least 10 substantial PRs to the codebase
- IV. Reviewed or got at least 30 PRs merged to the codebase

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bullet numbering (e.g., "1", "B", "III", "IV") will be removed in final version. Added them in here to facilitate referencing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the new draft to get rid of qualitative vs quantitative breakouts.

Copy link
Contributor Author

@nick-adkins nick-adkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added responses

Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor nits, but in general this looks great!


#### Responsibilities

- Keep participating!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short on to the point 😉


#### Privileges

- Tests run against their PRs automatically
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know this is true with gh actions? Also again PR => pull requests


#### Prerequisites

- Enabled two-factor authentication on their GitHub account
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make it easy to understand what it means, link to https://help.github.com/articles/about-two-factor-authentication

- Have made contributions to the project in the form of:
- Authoring or reviewing PRs on GitHub. At least one PR must be **merged**.
- Filing or commenting on issues on GitHub
- Contributing to a project, or community discussions (e.g. meetings, Slack,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, maybe adding a "meaningful contribution" or someting along the lines that is both vague but also open ended, in general something that will allow us to filter out any kind of 👍's and similar

nick-adkins and others added 4 commits August 27, 2025 13:03
Co-authored-by: Maciej Szulik <maciej@defenseunicorns.com>
Signed-off-by: nick-adkins <nick@defenseunicorns.com>
Co-authored-by: Maciej Szulik <maciej@defenseunicorns.com>
Signed-off-by: nick-adkins <nick@defenseunicorns.com>
Co-authored-by: Maciej Szulik <maciej@defenseunicorns.com>
Signed-off-by: nick-adkins <nick@defenseunicorns.com>
Signed-off-by: nick-adkins <nick@defenseunicorns.com>
Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, looking forward to adding this to our project

It also defines the process by which users can request to change roles. These roles are progressive, in that responsibilites and pre-requisites apply to subsequent rungs in the ladder.

- [Roles](#roles)
- [Community Participants](#community-participants)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: updating #heading-links to match headers


- [Roles](#roles)
- [Community Participants](#community-participants)
- [Contributors](#contributors)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add Community Members header


#### Prerequisites

Experience as a Community Member for at least 6 months
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: match bullet format of other prereq sections -

Updated based on comments/feedback/suggestions

Signed-off-by: nick-adkins <nick@defenseunicorns.com>
Copy link
Contributor Author

@nick-adkins nick-adkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made changes based on feedback/suggestions.

Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mkcp mkcp added this pull request to the merge queue Sep 3, 2025
Merged via the queue into main with commit 9f8994d Sep 3, 2025
23 checks passed
@mkcp mkcp deleted the nick-adkins-contributor-ladder-2 branch September 3, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants