Increase Extensibility to Add Kotlin Coroutines Support #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Made minor change ... renamed isSuspend to isSuspendable for consistency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A field named
isSuspendis added toRouteDefinitionto indicate that the current route is using a suspend method or not. Also, all fields ofRouteDefinitionhas beenprotectedto being able to set their value from a derived class.Also there was a change in
InjectionProvider.hasInjectionin that the method will return true for classes which has only one constructor. This way we can omit the@Injectannotation for classes that has only one constructor.