fix(kms-connector): put decrypt adapter into a separate async task #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the KMS connector's logging and asynchronous task handling. The main purpose is to put decrypt adapter operations into separate async tasks and standardize log message formatting throughout the codebase.
Key changes include:
- Wrapping decryption response operations in separate async tasks to prevent blocking
- Standardizing log message prefixes (removing emojis and using consistent bracket notation)
- Reducing transaction interval from 3 seconds to 100 milliseconds for better performance
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| kms_core_adapters/service.rs | Updates log message formatting for decryption requests |
| gw_adapters/events/adapter.rs | Removes emoji from event processing log messages |
| gw_adapters/decryption/adapter.rs | Changes transaction interval and improves log formatting |
| core/event_processor/processors.rs | Standardizes log prefixes and adjusts log levels |
| core/decryption/handler.rs | Wraps decryption operations in async tasks and updates logging |
| core/coordination/scheduler.rs | Removes emojis from scheduler log messages |
eudelins-zama
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and simplifying logs even further