Rudy/release/reorgs #551
Merged
Rudy/release/reorgs #551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudy-6-4
commented
Jul 11, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
rudy-6-4
commented
Jul 11, 2025
rudy-6-4
commented
Jul 11, 2025
819e4f3 to
f866b22
Compare
7d63331 to
0bdd7f4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
0bdd7f4 to
5e7f08c
Compare
goshawk-3
reviewed
Jul 24, 2025
coprocessor/fhevm-engine/fhevm-listener/src/cmd/block_history.rs
Outdated
Show resolved
Hide resolved
759fc25 to
1917224
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements blockchain reorganization (reorg) detection and handling for the fhevm-listener service. The changes add the ability to detect when the blockchain has reorganized and ensure no events are lost during these reorganizations.
- Adds comprehensive reorg detection using block history tracking
- Implements missing ancestor block retrieval during reorgs
- Adds integration tests for reorg scenarios with event emission and validation
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
integration_test.rs |
Adds reorg simulation tests and modifies event emission to support reorg testing scenarios |
mod.rs |
Implements core reorg detection logic with block history tracking and missing ancestor retrieval |
block_history.rs |
New module for maintaining blockchain history to detect reorganizations |
Cargo.toml |
Adds anyhow dependency for error handling |
coprocessor-cargo-tests.yml |
Adds CI test for reorg scenarios |
coprocessor/fhevm-engine/fhevm-listener/tests/integration_test.rs
Outdated
Show resolved
Hide resolved
coprocessor/fhevm-engine/fhevm-listener/tests/integration_test.rs
Outdated
Show resolved
Hide resolved
1917224 to
b7298a0
Compare
antoniupop
approved these changes
Jul 29, 2025
dartdart26
approved these changes
Jul 29, 2025
coprocessor/fhevm-engine/fhevm-listener/src/cmd/block_history.rs
Outdated
Show resolved
Hide resolved
b7298a0 to
415d75a
Compare
|
I have added retry for get_block and get_current_block |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.