Skip to content
This repository was archived by the owner on Sep 14, 2020. It is now read-only.

Provoke handling cycles even with no arbitrary field preservation #343

Merged
merged 2 commits into from
Apr 7, 2020
Merged

Provoke handling cycles even with no arbitrary field preservation #343

merged 2 commits into from
Apr 7, 2020

Conversation

nolar
Copy link
Contributor

@nolar nolar commented Apr 6, 2020 •
edited
Loading

What do these changes do?

Trigger the after-sleep handling cycles via the progress storage, the same way as it is triggered for the no-sleep handlers.

Description

This aspect was unintentionally forgotten in #331, where the handlers' persistence was made configurable.

If the resource would have no arbitrary field preservation (e.g. for built-in resources), the dummy patching would be silently ignored by K8s API.

With this PR, the dummy patches are made the same way as the regular handlers are patched, so the handling cycles are always provoked after the sleeps.

Issues/PRs

Issues: #308 #23 #283 #321
Related: #331

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • The code addresses only the mentioned problem, and this problem only
  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt

@nolar nolar added the bug Something isn't working label Apr 6, 2020
@zincr
Copy link

zincr bot commented Apr 6, 2020 •
edited
Loading

🤖 zincr found 0 problems , 0 warnings

✅ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing

@zincr
Copy link

zincr bot commented Apr 6, 2020

🤖 zincr found 1 problem , 0 warnings

❌ Approvals
✅ Large Commits
✅ Specification
✅ Dependency Licensing

Details on how to resolve are provided below

Approvals

All proposed changes must be reviewed by project maintainers before they can be merged

Not enough people have approved this pull request - please ensure that 1 additional user, who have not contributed to this pull request approve the changes.

  • ✅ Approved by PR author @nolar
  • ❌ 1 additional approval needed
     

@nolar nolar requested a review from mnarodovitch April 6, 2020 21:54
@nolar nolar merged commit 03c6da7 into zalando-incubator:master Apr 7, 2020
@nolar nolar deleted the dummy-patches-via-annotations branch April 7, 2020 12:06
@nolar nolar added this to the 0.27 milestone May 11, 2020
@kopf-archiver kopf-archiver bot mentioned this pull request Aug 19, 2020
Closed
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@mnarodovitch mnarodovitch mnarodovitch approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.27: daemons, timers, configs, storages
Development

Successfully merging this pull request may close these issues.
2 participants
@nolar @mnarodovitch