Skip to content
This repository was archived by the owner on Sep 14, 2020. It is now read-only.

Update the Dockerfile to fix the handlers.py path inside container #303

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Update the Dockerfile to fix the handlers.py path inside container #303

merged 1 commit into from
Feb 20, 2020

Conversation

prakashkl88
Copy link
Contributor

When the Dockerfile mentioned here is copied as is, it does not run the container as the path inside the container is incorrect. Fixing that

What do these changes do?

Reflects the correct Dockerfile doc to be used

Description

Incorrect path in README.doc

Enhanced UX

N/A

End-users

N/A

No

Type of changes

  • Mostly documentation and examples (no code changes)

Checklist

  • The code addresses only the mentioned problem, and this problem only

@prakashkl88
Update the Dockerfile to fix the handlers.py path inside container
cf5e03b 
When the Dockerfile mentioned here is copied as is, it does not run the container as the path inside the container is incorrect. Fixing that
@prakashkl88 prakashkl88 requested a review from nolar as a code owner January 30, 2020 17:26
@zincr
Copy link

zincr bot commented Jan 30, 2020 •
edited
Loading

🤖 zincr found 1 problem , 0 warnings

❌ Specification
✅ Large Commits
✅ Approvals
✅ Dependency Licensing

Details on how to resolve are provided below

Specification

All pull requests must follow certain rules for content length and form

Please ensure the follow issues are resolved:

  • ✅ Pull Request Title must be atleast 8 characters
  • ✅ Pull Request body must be atleast 8 characters
  • ❌ Pull Request body must contain issue number
     

@nolar nolar requested a review from aweller January 30, 2020 18:08
@nolar nolar merged commit 319ea43 into zalando-incubator:master Feb 20, 2020
@kopf-archiver kopf-archiver bot mentioned this pull request Aug 19, 2020
Closed
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aweller aweller Awaiting requested review from aweller

2 more reviewers

@haikoschol haikoschol haikoschol approved these changes

@nolar nolar nolar approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prakashkl88 @haikoschol @nolar