I experienced hangs caused by the array splitting pass in a C/C++ debug build a few weeks ago. It may not be the only pass that reports false success, though. The release build crashed (GCC 4.8.3 / Linux) and I didn't really feel like digging into that code. Your online demo works surprisingly well compared to my executable - in fact, it looks very promising!

Here is the diff of my "hackfix": The edits further below were to make it compile and please note it's not a proper solution - just stuff that made it run and terminate again somehow.

diff --git a/src/glsl/glsl_optimizer.cpp b/src/glsl/glsl_optimizer.cpp
index 001e7e6..1bf8ce8 100644
--- a/src/glsl/glsl_optimizer.cpp
+++ b/src/glsl/glsl_optimizer.cpp
@@ -197,7 +197,7 @@ struct glslopt_shader

 static inline void debug_print_ir (const char* name, exec_list* ir, _mesa_glsl_parse_state* state, void* memctx)
 {
-   #if 0
+   #if 1
    printf("**** %s:\n", name);
 // _mesa_print_ir (ir, state);
    char* foobar = _mesa_print_ir_glsl(ir, state, ralloc_strdup(memctx, ""), kPrintGlslFragment);
@@ -477,7 +477,7 @@ static void do_optimization_passes(exec_list* ir, bool linked, _mesa_glsl_parse_
        progress2 = lower_vector_insert(ir, false); progress |= progress2; if (progress2) debug_print_ir ("After lower vector insert", ir, state, mem_ctx);
        progress2 = do_swizzle_swizzle(ir); progress |= progress2; if (progress2) debug_print_ir ("After swizzle swizzle", ir, state, mem_ctx);
        progress2 = do_noop_swizzle(ir); progress |= progress2; if (progress2) debug_print_ir ("After noop swizzle", ir, state, mem_ctx);
-       progress2 = optimize_split_arrays(ir, linked, state->metal_target && state->stage == MESA_SHADER_FRAGMENT); progress |= progress2; if (progress2) debug_print_ir ("After split arrays", ir, state, mem_ctx);
+       progress2 = optimize_split_arrays(ir, linked, state->metal_target && state->stage == MESA_SHADER_FRAGMENT); /*progress |= progress2; */ if (progress2) debug_print_ir ("After split arrays", ir, state, mem_ctx);
        progress2 = optimize_split_vectors(ir, linked, OPT_SPLIT_ONLY_UNUSED); progress |= progress2; if (progress2) debug_print_ir("After split unused vectors", ir, state, mem_ctx);
        progress2 = optimize_redundant_jumps(ir); progress |= progress2; if (progress2) debug_print_ir ("After redundant jumps", ir, state, mem_ctx);

diff --git a/src/glsl/main.cpp b/src/glsl/main.cpp
index feed100..be08d9a 100644
--- a/src/glsl/main.cpp
+++ b/src/glsl/main.cpp
@@ -40,11 +40,13 @@

 static int glsl_version = 330;

+/*
 extern "C" void
 _mesa_error_no_memory(const char *caller)
 {
    fprintf(stderr, "Mesa error: out of memory in %s", caller);
 }
+*/

 static void
 initialize_context(struct gl_context *ctx, gl_api api)
diff --git a/src/glsl/standalone_scaffolding.cpp b/src/glsl/standalone_scaffolding.cpp
index b338e92..beaa943 100644
--- a/src/glsl/standalone_scaffolding.cpp
+++ b/src/glsl/standalone_scaffolding.cpp
@@ -54,7 +54,6 @@ _mesa_error_no_memory(const char *caller)
 {
 }

-
 struct gl_shader *
 _mesa_new_shader(struct gl_context *ctx, GLuint name, GLenum type)
 {
diff --git a/tests/glsl_optimizer_tests.cpp b/tests/glsl_optimizer_tests.cpp
index 7dab3d1..a1e0da8 100644
--- a/tests/glsl_optimizer_tests.cpp
+++ b/tests/glsl_optimizer_tests.cpp
@@ -317,7 +317,7 @@ static bool CheckMetal (bool vertex, bool gles, const std::string& testName, con
 {
 #if !GOT_GFX
    return true; // just assume it's ok
-#endif
+#else

    FILE* f = fopen ("metalTemp.metal", "wb");
    fwrite (source.c_str(), source.size(), 1, f);
@@ -330,6 +330,7 @@ static bool CheckMetal (bool vertex, bool gles, const std::string& testName, con
        return false;
    }
    return true;
+#endif
 }

Compile with Emscripten with Optimizations #1

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions