api: Don't allow connecting to servers <7.0; show nag banner on <8.0 #5922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last one of these was 48f1e47 on 2025-04-04, released in v27.234 on 2025-04-24. As mentioned there, the last 6.x release, 6.2, went out on 2023-05-19, which is outside the 18-month window. We've been showing the nag banner for that release since v27.234, so we can expect server admins to have seen and acted on it, and we can refuse to connect. The last 7.x release, 7.5, went out on 2023-11-16, which turns 18 months old tomorrow, 2025-05-16. So we can start to show the nag banner for that.
ce4444b to
40dd302
Compare
|
Thanks for taking care of this! Looks good; merging. |
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this pull request
May 21, 2025
This goes rather farther than zulip#1456, which is for bumping this number just to 5.0. This is OK; we recently bumped zulip-mobile to use 7.0, in the v27.235 release. zulip-mobile shows a "nag banner" to nudge server admins to upgrade. As of v27.235 (PR zulip/zulip-mobile#5922), that banner appears on 7.x servers, the latest 7.x having recently aged out of our 18-month support window. So we should feel comfortable nudging this number in zulip-flutter to 8.0 once v27.235 has been out for a little while. Fixes: zulip#1456
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last one of these was 48f1e47 on 2025-04-04, released in v27.234 on 2025-04-24.
As mentioned there, the last 6.x release, 6.2, went out on 2023-05-19, which is outside the 18-month window. We've been showing the nag banner for that release since v27.234, so we can expect server admins to have seen and acted on it, and we can refuse to connect.
The last 7.x release, 7.5, went out on 2023-11-16, which turns 18 months old tomorrow, 2025-05-16. So we can start to show the nag banner for that.