deps: Use a patched rn-fetch-blob to fix Android 14+ crash #5904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates rn-fetch-blob to a version with one cherry-picked commit atop the v0.11.2 we were previously using: zulip/rn-fetch-blob@e17b2a51c The rn-fetch-blob package itself is no longer maintained: joltup/rn-fetch-blob#863 There's a fork that is maintained, `react-native-blob-util`: https://npmjs.com/package/react-native-blob-util That fork addressed the Android 14 requirement to set an explicit RECEIVER_EXPORTED flag (zulip#5903), merging a fix: RonRadtke/react-native-blob-util#303 RonRadtke/react-native-blob-util#306 Our fix is cherry-picked from that one. (If this app weren't a legacy codebase in maintenance mode, we'd take the time to upgrade this dependency more generally, probably switching to the react-native-blob-util fork. As is, we'll skip that and use the time to focus on completing the new Flutter app.) Fixes: zulip#5903
|
LGTM, thanks! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates rn-fetch-blob to a version with one cherry-picked commit atop the v0.11.2 we were previously using:
zulip/rn-fetch-blob@e17b2a51c
The rn-fetch-blob package itself is no longer maintained:
joltup/rn-fetch-blob#863
There's a fork that is maintained,
react-native-blob-util:https://npmjs.com/package/react-native-blob-util
That fork addressed the Android 14 requirement to set an explicit RECEIVER_EXPORTED flag (#5903), merging a fix:
RonRadtke/react-native-blob-util#303
RonRadtke/react-native-blob-util#306
Our fix is cherry-picked from that one.
(If this app weren't a legacy codebase in maintenance mode, we'd take the time to upgrade this dependency more generally, probably switching to the react-native-blob-util fork. As is, we'll skip that and use the time to focus on completing the new Flutter app.)
Fixes: #5903