Skip to content

android build: Set strict version 0.10.4 for RN's dependency SoLoader #5902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2024
Merged

android build: Set strict version 0.10.4 for RN's dependency SoLoader #5902

merged 1 commit into from
Oct 18, 2024

Conversation

chrisbobbe
Copy link
Contributor

Fixes: #5901

@chrisbobbe chrisbobbe requested a review from gnprice October 18, 2024 20:15
@chrisbobbe
Copy link
Contributor Author

After this change:

$ tools/gradle :app:dependencies | grep com.facebook.soloader:soloader
+--- com.facebook.soloader:soloader:{strictly 0.10.4} -> 0.10.4
|    +--- com.facebook.soloader:soloader:0.10.3 -> 0.10.4 (*)
+--- com.facebook.soloader:soloader:{strictly 0.10.4} -> 0.10.4
|    +--- com.facebook.soloader:soloader:0.10.3 -> 0.10.4 (*)
+--- com.facebook.soloader:soloader:{strictly 0.10.4} -> 0.10.4 (c)
+--- com.facebook.soloader:soloader:{strictly 0.10.4} -> 0.10.4
|    +--- com.facebook.soloader:soloader:0.10.3 -> 0.10.4
|    |    |    \--- com.facebook.soloader:soloader:0.10.1 -> 0.10.4 (*)
|    |    |    |    \--- com.facebook.soloader:soloader:0.10.1 -> 0.10.4 (*)
+--- com.facebook.soloader:soloader:{strictly 0.10.4} -> 0.10.4 (*)
|    +--- com.facebook.soloader:soloader:0.10.3 -> 0.10.4 (*)
+--- com.facebook.soloader:soloader:{strictly 0.10.4} -> 0.10.4
|    +--- com.facebook.soloader:soloader:0.10.3 -> 0.10.4 (*)
+--- com.facebook.soloader:soloader:{strictly 0.10.4} -> 0.10.4 (c)
|    +--- com.facebook.soloader:soloader:0.10.3 -> 0.10.4
|    |    |    \--- com.facebook.soloader:soloader:0.10.1 -> 0.10.4 (*)
|    |    |    |    \--- com.facebook.soloader:soloader:0.10.1 -> 0.10.4 (*)
+--- com.facebook.soloader:soloader:{strictly 0.10.4} -> 0.10.4 (*)
|    +--- com.facebook.soloader:soloader:0.10.3 -> 0.10.4 (*)
+--- com.facebook.soloader:soloader:0.10.4 (n)
+--- com.facebook.soloader:soloader:{strictly 0.10.4} -> 0.10.4
+--- com.facebook.soloader:soloader:{strictly 0.10.4} -> 0.10.4
|    +--- com.facebook.soloader:soloader:0.10.3 -> 0.10.4 (*)
+--- com.facebook.soloader:soloader:{strictly 0.10.4} -> 0.10.4 (c)
+--- com.facebook.soloader:soloader:{strictly 0.10.4} -> 0.10.4
|         |    \--- com.facebook.soloader:soloader:0.10.1 -> 0.10.4
+--- com.facebook.soloader:soloader:{strictly 0.10.4} -> 0.10.4 (*)
|    |    |    \--- com.facebook.soloader:soloader:0.10.1 -> 0.10.4 (*)
|    +--- com.facebook.soloader:soloader:0.10.3 -> 0.10.4 (*)
+--- com.facebook.soloader:soloader:{strictly 0.10.4} -> 0.10.4
|    +--- com.facebook.soloader:soloader:0.10.3 -> 0.10.4 (*)
+--- com.facebook.soloader:soloader:{strictly 0.10.4} -> 0.10.4 (c)
|         |    \--- com.facebook.soloader:soloader:0.10.1 -> 0.10.4
+--- com.facebook.soloader:soloader:{strictly 0.10.4} -> 0.10.4 (*)
|    |    |    \--- com.facebook.soloader:soloader:0.10.1 -> 0.10.4 (*)
|    +--- com.facebook.soloader:soloader:0.10.3 -> 0.10.4 (*)

And a quick manual smoke test of the app on an emulator (API level 35) showed no issues.

@gnprice
Copy link
Member

gnprice commented Oct 18, 2024

Thanks for taking care of this! Looks good; merging.

@gnprice gnprice merged commit fc23edd into zulip:main Oct 18, 2024
1 check passed
@chrisbobbe chrisbobbe deleted the pr-soloader-0-10-4 branch October 18, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnprice gnprice Awaiting requested review from gnprice

Assignees

@gnprice gnprice

Labels
a-Android P1 high-priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade SoLoader to 0.10.4
2 participants
@chrisbobbe @gnprice